Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.postcss-cli: add passthru.tests #130204

Merged
merged 1 commit into from
Jul 18, 2021
Merged

nodePackages.postcss-cli: add passthru.tests #130204

merged 1 commit into from
Jul 18, 2021

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jul 14, 2021

Motivation for this change

See #130027.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Luflosi Luflosi mentioned this pull request Jul 14, 2021
Merged
11 tasks
@Luflosi Luflosi requested a review from roberth July 14, 2021 16:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 14, 2021
@symphorien
Copy link
Member

This could be run as installCheckPhase instead.

@roberth
Copy link
Member

roberth commented Jul 14, 2021

This could be run as installCheckPhase instead.

installCheckPhase doesn't have a clean environment. The lack of node_modules or related environment variables in the extra derivation is an important feature.

@roberth roberth mentioned this pull request Jul 14, 2021
Merged
11 tasks
@Luflosi Luflosi force-pushed the postcss-cli-add-tests branch from d6e8a8e to b822105 Compare July 14, 2021 18:13
@Luflosi Luflosi marked this pull request as draft July 14, 2021 18:23
@Luflosi Luflosi mentioned this pull request Jul 18, 2021
Merged
11 tasks
@Luflosi Luflosi force-pushed the postcss-cli-add-tests branch from b822105 to a2bdce7 Compare July 18, 2021 12:01
@Luflosi Luflosi marked this pull request as ready for review July 18, 2021 12:02
@Luflosi Luflosi force-pushed the postcss-cli-add-tests branch from a2bdce7 to 703b9b1 Compare July 18, 2021 12:06
roberth
roberth reviewed Jul 18, 2021
View reviewed changes
pkgs/development/node-packages/default.nix
simple-execution = pkgs.callPackage ./package-tests/postcss-cli.nix {
inherit (self) postcss-cli;
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also relevant for the autoprefixer package. You could add it there as well.

roberth
roberth approved these changes Jul 18, 2021
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@roberth roberth merged commit 03a17d7 into NixOS:master Jul 18, 2021
@Luflosi Luflosi deleted the postcss-cli-add-tests branch August 17, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luflosi @symphorien @roberth