nixos/nix-daemon: fix registry flake type #131814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
roberth
reviewed
Jul 31, 2021
| @@ -458,7 +458,7 @@ in | |||
| description = "The flake reference to which <option>from></option> is to be rewritten."; | |||
| }; | |||
| flake = mkOption { | |||
| type = types.unspecified; | |||
| type = types.attrs; | |||
There was a problem hiding this comment.
Type does not match the default or the example. What's going on with all three?
There was a problem hiding this comment.
Thanks, oversight fixed in force-push. The literalExample is actually correct and refers to a hypothetical nixpkgs input, which is a flake, hence an attrs.
Before this commit, the `flake` option was typed with `types.unspecified`. This type get's merged via [`mergeDefaultOption`](https://github.com/NixOS/nixpkgs/blob/ebb592a04c5282f316d60cd4aba066f6e5d74b65/lib/options.nix#L119-L128), which has a line ```nix else if all isFunction list then x: mergeDefaultOption loc (map (f: f x) list) ``` `lib.isFunction` detects an attrs in the shape of `{__functor = ...}` as a function and hence this line substitutes such attrs with a function (f: f x). If now, a flake input has a `__functor` as it's output, this will coerce the once attrs to a function. This breaks a lot of things later in the stack, for example a later `lib.filterAttrs seive <LAMBDA>` will fail for obious reasons. According to @infinisil, `types.unspecified` is due to deprecation. In the meantime this PR provides a specific fix for the specific problem discovered.
blaggacao
force-pushed
the
fix-nix-daemon-registry-type-unspecified-error
branch
from
73e3095
to
ecae25c
Compare
10 tasks
roberth
approved these changes
Aug 1, 2021
|
@roberth I'd say this warrants backporting, does it? |
1 task
|
Successfully created backport PR #132363 for |
Pacman99
pushed a commit
to divnix/digga
that referenced
this pull request
Feb 23, 2022
There was never an intention to setup the registry with aliases, which would not avoid a network call ayhow if an input is not specified as an registry-resolvable input. At the same time, this clarification also eliniates an error that is addressed upstream via NixOS/nixpkgs#131814 --- work-around: for spurious reasons w.r.t. functor attrs in module system Without any obvious reason, the module system appears to substitute attrs that contain a `__functor` with the value of that functor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the
flakeoption was typed withtypes.unspecified.This type get's merged via
mergeDefaultOption, which has a linelib.isFunctiondetects an attrs in the shape of{__functor = ...}asa function and hence this line substitutes such attrs with a function
(
f: f x).If now, a flake input has a
__functoras it's output, this willcoerce the once attrs to a function. This breaks a lot of things later
in the stack, for example a later
lib.filterAttrs seive <LAMBDA>willfail for obious reasons.
According to @infinisil,
types.unspecifiedis due to deprecation. Inthe meantime this PR provides a specific fix for the specific problem
discovered.
EDIT: this needs quite some back-porting, please someone can add the respective labels?