matrix-synapse: add e-mail delivery regression test #135094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
duplicate of #132900 please review the other PR |
|
Thanks, missed that one unfortunately. I will then drop the fixing commits and only leave the regression test in. |
mguentner
force-pushed
the
matrix-synapse-modern-twisted
branch
from
510d1cd to
cbd9cdd
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
mguentner
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
|
Indeed, #132900 @ b07c07bf058da808a2dc77e6c1005b08c28c10be fixes this regression test. |
13 tasks
twisted is used in matrix-synapse for smtp handling. Mostly this is used for password resets, but also notifications are delivered that way. older versions of twisted require the e-mail server to have TLS1.0 enabled. Obviously, quite a lot of servers have this disabled which means synapse won't be able to deliver mails using such servers. matrix-synapse issue: matrix-org/synapse#6211
mguentner
force-pushed
the
matrix-synapse-modern-twisted
branch
from
cbd9cdd to
076074a
Compare
Ma27
approved these changes
Aug 23, 2021
|
The test seems fine and btw passes when rebasing current nixpkgs master onto this branch :) |
|
@Ma27 Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a regression test for the behavior described in
Should be fixed with #132900
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)CC @Ma27 @fadenb @sumnerevans