-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipewire: 0.3.33 -> 0.3.34 #135819
pipewire: 0.3.33 -> 0.3.34 #135819
Conversation
Result of 2 packages marked as broken and skipped:
26 packages failed to build:
67 packages skipped due to time constraints:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
, ffmpegSupport ? true, ffmpeg ? null | ||
, bluezSupport ? true, bluez ? null, sbc ? null, libfreeaptx ? null, ldacbt ? null, fdk_aac ? null | ||
, gstreamerSupport ? true | ||
, gst_all_1 ? null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need ? null
for all optional dependencies?
They are available by callPackage
and are lazy evaluated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly sure that is just a "that's just how it has always been done" case. At least for me it has, it was that way for existing optional deps so I used the same pattern for the ones I added.
Can we get this merged? It resolves a few critical regressions on 0.3.33. |
@jtojnar could you please review this? |
Successfully created backport PR #136392 for |
Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)