Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks: add bash/zsh completion #136507

Merged
merged 1 commit into from
Sep 3, 2021
Merged

luarocks: add bash/zsh completion #136507

merged 1 commit into from
Sep 3, 2021

Conversation

teto
Copy link
Member

@teto teto commented Sep 2, 2021 •
edited
Loading

Motivation for this change

I use luarocks regularly enough that it comes in handy. Was possible thanks to
luarocks/luarocks#1035 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@teto teto mentioned this pull request Sep 2, 2021
Merged
@ofborg ofborg bot requested a review from 7c6f434c September 2, 2021 21:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Sep 2, 2021
@teto teto mentioned this pull request Sep 2, 2021
Open
30 tasks
@7c6f434c 7c6f434c merged commit e4f82b3 into NixOS:master Sep 3, 2021
@teto teto deleted the luarocks-completion branch September 3, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teto @7c6f434c