Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_13.compiler-rt: Mark as broken on Aarch64 #136629

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Sep 3, 2021

To avoid unnecessary builds but this needs to be fixed ASAP. Chromium
already depends on it and a lot of additional packages, including Mesa,
will depend on it after the stable release.

Motivation for this change

I made some progress in #136574 but it needs more work and I lack time.

cc @thefloweringash as the Aarch64 maintainer for Chromium

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

To avoid unnecessary builds but this needs to be fixed ASAP. Chromium
already depends on it and a lot of additional packages, including Mesa,
will depend on it after the stable release.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 3, 2021
@primeos primeos merged commit cd0ec0e into NixOS:master Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Successfully created backport PR #136640 for release-21.05.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

The process '/usr/bin/git' failed with exit code 1

@r-burns
Copy link
Contributor

r-burns commented Sep 4, 2021

How about just disabling libfuzzer?

@primeos
Copy link
Member Author

primeos commented Sep 4, 2021

@r-burns unfortunately I don't have time to take a look, as I noted above. Feel free to submit a PR.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants