Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpackFile: ignore timestamp warnings #137209

Merged
merged 1 commit into from
Oct 25, 2021
Merged

unpackFile: ignore timestamp warnings #137209

merged 1 commit into from
Oct 25, 2021

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Sep 9, 2021

in rare cases, tar xf somefile.tar says "time stamp is in the future" or "implausibly old time stamp"

for example in fetchipfs #136688ipfs/kubo#8406 and golang/go#48275

these warnings should be safe to ignore

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member

dasJ commented Sep 9, 2021

Maybe target the staging branch with this

@Artturin Artturin changed the base branch from master to staging September 22, 2021 03:35
Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both work

nix build ".#mate.marco.src"
xz -d < result | tar xf - --warning=no-timestamp
nix build ".#streamripper.src"
tar xf result --warning=no-timestamp

and coreutils builds

@Artturin Artturin merged commit 0809a3a into NixOS:staging Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants