dockerTools: test pullImage #139892
Merged
dockerTools: test pullImage #139892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so it won't break when the fetcher doesn't use name correctly.
roberth
added
6.topic: docker tools
6.topic: testing
roberth
commented
Sep 29, 2021
Comment on lines
+98
to
+106
| # Same example, but re-fetches every time the fetcher implementation changes. | ||
| # NOTE: Only use this for testing, or you'd be wasting a lot of time, network and space. | ||
| testNixFromDockerHub = pkgs.invalidateFetcherByDrvHash pullImage { | ||
| imageName = "nixos/nix"; | ||
| imageDigest = "sha256:85299d86263a3059cf19f419f9d286cc9f06d3c13146a8ebbb21b3437f598357"; | ||
| sha256 = "19fw0n3wmddahzr20mhdqv6jkjn1kanh6n2mrr08ai53dr8ph5n7"; | ||
| finalImageTag = "2.2.1"; | ||
| finalImageName = "nix"; | ||
| }; |
There was a problem hiding this comment.
Should be moved but so should other attrs. Not going to do #139895 in this PR.
tfc
approved these changes
Sep 29, 2021
|
@GrahamcOfBorg test docker-tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixed-output derivations normally don't run when testing. Change the name based on fetcher implementation (drvHash) so it runs when it needs to. See https://nixos.org/manual/nixpkgs/unstable/#sec-pkgs-invalidateFetcherByDrvHash
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)