Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gdm: switch to rfc42 style settings #140096

Merged
merged 1 commit into from
Oct 1, 2021
Merged

nixos/gdm: switch to rfc42 style settings #140096

merged 1 commit into from
Oct 1, 2021

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 30, 2021 •
edited
Loading

TODO add example before merging

Motivation for this change
Things done

as a sidenote i noticed that autologin wasn't working (atleast in a vm) which may be due to the fact that the gdm pam rules are very out of date because they were last updated when they were added many years ago. i'll try updating them

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin
Copy link
Member Author

Artturin commented Sep 30, 2021 •
edited
Loading

@8573 please test https://nixos.wiki/wiki/Nixpkgs/Reviewing_changes#Modules

EDIT gotta change the dconf too

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 30, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 30, 2021
@Artturin Artturin marked this pull request as draft October 1, 2021 01:20
aanderse
aanderse approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

nixos/modules/services/x11/display-managers/gdm.nix Outdated Show resolved Hide resolved
@Artturin
Copy link
Member Author

Artturin commented Oct 1, 2021

to solve #138627
using rf42 settings
we could use what i've commented her #54150 (comment)
but its not used anywhere else

@Artturin Artturin marked this pull request as ready for review October 1, 2021 18:06
@Artturin
Copy link
Member Author

Artturin commented Oct 1, 2021

Built the options manual and checked that it looks correct

@Artturin Artturin merged commit 8296c4d into NixOS:master Oct 1, 2021
@Artturin Artturin deleted the gdmoptions branch October 1, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artturin @aanderse