Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add list of supported systems #140428

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 3, 2021

Adds the first 3 tiers of RFC0046 that are being used in flake.nix.

Motivation for this change

Let's integrate the list of supported systems. This is just the minimum.

/cc @7c6f434c @Ericson2314

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Adds the first 3 tiers of RFC0046 that are being used in flake.nix.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 3, 2021
@figsoda
Copy link
Member

figsoda commented Oct 4, 2021

is this a successor of #123117 ?

@zimbatm
Copy link
Member Author

zimbatm commented Oct 4, 2021

It's a subset. I want to rebase the other PR on top of this one once it's merged.

@zimbatm zimbatm merged commit 8377a7b into NixOS:master Oct 5, 2021
@zimbatm zimbatm deleted the rfc0046-supported-systems branch October 5, 2021 09:14
@veehaitch
Copy link
Member

Maybe that's perfectly intended but this PR wipes aarch64-darwin from the legacyPackages attribute:

# nix flake show github:nixos/nixpkgs/master
github:nixos/nixpkgs/66b6bd0072143f955ab983222b54a8cc626f1651
├───checks
│   └───x86_64-linux
│       └───tarball: derivation 'nixpkgs-tarball-21.11pre20211006.66b6bd0'
├───htmlDocs: unknown
├───legacyPackages
warning: │   ├───aarch64-linux: omitted (use '--legacy' to show)
warning: │   ├───armv6l-linux: omitted (use '--legacy' to show)
warning: │   ├───armv7l-linux: omitted (use '--legacy' to show)
warning: │   ├───i686-linux: omitted (use '--legacy' to show)
warning: │   ├───mipsel-linux: omitted (use '--legacy' to show)
warning: │   ├───x86_64-darwin: omitted (use '--legacy' to show)
warning: │   └───x86_64-linux: omitted (use '--legacy' to show)
├───lib: unknown
└───nixosModules
    └───notDetected: NixOS module

"armv6l-linux"
"armv7l-linux"
"i686-linux"
"mipsel-linux"
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch64-darwin is missing here but mipsel appeared instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad I'm sharing the blame with 3 other reviewers :p

PR incoming.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants