-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add list of supported systems #140428
Conversation
Adds the first 3 tiers of RFC0046 that are being used in flake.nix.
is this a successor of #123117 ? |
It's a subset. I want to rebase the other PR on top of this one once it's merged. |
Maybe that's perfectly intended but this PR wipes # nix flake show github:nixos/nixpkgs/master
github:nixos/nixpkgs/66b6bd0072143f955ab983222b54a8cc626f1651
├───checks
│ └───x86_64-linux
│ └───tarball: derivation 'nixpkgs-tarball-21.11pre20211006.66b6bd0'
├───htmlDocs: unknown
├───legacyPackages
warning: │ ├───aarch64-linux: omitted (use '--legacy' to show)
warning: │ ├───armv6l-linux: omitted (use '--legacy' to show)
warning: │ ├───armv7l-linux: omitted (use '--legacy' to show)
warning: │ ├───i686-linux: omitted (use '--legacy' to show)
warning: │ ├───mipsel-linux: omitted (use '--legacy' to show)
warning: │ ├───x86_64-darwin: omitted (use '--legacy' to show)
warning: │ └───x86_64-linux: omitted (use '--legacy' to show)
├───lib: unknown
└───nixosModules
└───notDetected: NixOS module |
"armv6l-linux" | ||
"armv7l-linux" | ||
"i686-linux" | ||
"mipsel-linux" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aarch64-darwin is missing here but mipsel appeared instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad I'm sharing the blame with 3 other reviewers :p
PR incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds the first 3 tiers of RFC0046 that are being used in flake.nix.
Motivation for this change
Let's integrate the list of supported systems. This is just the minimum.
/cc @7c6f434c @Ericson2314
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)