Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srain: init at 1.3.0 #145069

Merged
merged 2 commits into from
Nov 8, 2021
Merged

srain: init at 1.3.0 #145069

merged 2 commits into from
Nov 8, 2021

Conversation

wineee
Copy link
Member

@wineee wineee commented Nov 8, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wineee wineee changed the title Srain srain: init at 1.3.0 Nov 8, 2021
@wineee wineee mentioned this pull request Nov 8, 2021
Closed
12 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2021
SuperSandro2000
SuperSandro2000 requested changes Nov 8, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

pkgs/applications/networking/irc/srain/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/irc/srain/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit ddb1587 into NixOS:master Nov 8, 2021
@wineee wineee deleted the srain branch May 9, 2022 13:59
@wineee wineee mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wineee @SuperSandro2000