Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tensorflow: fix for darwin #145149

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 9, 2021

Motivation for this change

Fixes: #144111
ZHF #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 9, 2021
@ofborg ofborg bot requested a review from abbradar November 9, 2021 01:10
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 9, 2021
@jonringer
Copy link
Contributor

cc @r-burns @risicle , can one of you please verify that it builds?

Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 145149 run on x86_64-darwin 1

17 packages marked as broken and skipped:
  • python38Packages.arviz
  • python38Packages.einops
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.rl-coach
  • python38Packages.tensorflow-probability
  • python39Packages.arviz
  • python39Packages.einops
  • python39Packages.graph_nets
  • python39Packages.mask-rcnn
  • python39Packages.optuna
  • python39Packages.pymc3
  • python39Packages.rl-coach
  • python39Packages.tensorflow-probability
  • tts
13 packages built:
  • libtensorflow
  • python38Packages.baselines
  • python38Packages.edward
  • python38Packages.scikit-tda
  • python38Packages.tensorflow (python38Packages.tensorflow-build ,python38Packages.tensorflow-build_2 ,python38Packages.tensorflowWithoutCuda ,python38Packages.tensorflow_2)
  • python38Packages.tflearn
  • python38Packages.umap-learn
  • python39Packages.baselines
  • python39Packages.edward
  • python39Packages.scikit-tda
  • python39Packages.tensorflow (python39Packages.tensorflow-build ,python39Packages.tensorflow-build_2 ,python39Packages.tensorflowWithoutCuda ,python39Packages.tensorflow_2)
  • python39Packages.tflearn
  • python39Packages.umap-learn

@Mic92 Mic92 merged commit b0e1168 into NixOS:master Nov 9, 2021
@risicle
Copy link
Contributor

risicle commented Nov 10, 2021

Built this successfully on macos 10.15 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorflow does not build on Darwin
5 participants