Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: 5.23.0 -> 5.23.1 #145412

Merged
merged 1 commit into from
Nov 10, 2021
Merged

signal-desktop: 5.23.0 -> 5.23.1 #145412

merged 1 commit into from
Nov 10, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 10, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from equirosa and ixmatus November 10, 2021 20:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 10, 2021
@primeos primeos merged commit a8506b6 into NixOS:master Nov 10, 2021
@github-actions github-actions bot mentioned this pull request Nov 10, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #145425 for release-21.05.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equirosa equirosa Awaiting requested review from equirosa

@ixmatus ixmatus Awaiting requested review from ixmatus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@primeos