Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantheon.wingpanel-indicator-sound: 6.0.0 -> 6.0.1 #146574

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Nov 19, 2021

Motivation for this change

Part of Pantheon 6.0.4 updates.

For upcoming package update, please check https://github.com/orgs/elementary/projects/90#column-16673367


About the backport workflow for 6.0.4 and 6.1

21.11 branch off is expected to happen before Pantheon 6.0.4 release cycle finishes. As mentioned in the 21.11 feature freeze issue, I will start backporting changes to 21.11 as soon as branch off is done (so this PR does not need a backport obviously).

What I backport

I WILL backport Pantheon updates that fits criteria for backporting changes before elementary shift their focus to Pantheon 7.

I WILL NOT backport updates for the following [unless necessary]:

  • Pantheon updates that introduces breaking changes and/or critical bugs and/or major regressions.
  • gnome-settings-daemon and mutter shipped by Pantheon
  • upstream (GNOME) updates for epiphany, file-roller, evince [I WILL backport downstream (elementary) patch updates when possible]
  • other non-Pantheon package updates

If you need a backport for these packages, please read the changes and test the update yourself when sending a PR, and make sure it fits criteria for backporting changes.

Why I backport

Seems that Pantheon is the only desktop in NixOS that backport feature updates so I add this section.

  • (Most importantly) Fits criteria for backporting changes
  • The number of rebuild is very very small and it is easy to rebuild my system to test the change.
  • Pantheon has feature updates every month which are also delivered to elementary OS 6 users.
  • We already offered backports when NixOS 20.03 and 20.09 was stable release (not in 21.05 because Pantheon 6 is a major update).

How I backport

Updates on master is done daily as I live on nixos-unstable and testing something is easy. The PR will be titled as pkg-name: from -> to for single package updates or Pantheon updates yyyy-mm-dd for multiple packages updates. Unless major concerns are raised all PRs are expected to be tested and merged before I open the next PR.

Updates on release-21.11 will be done monthly. When a release cycle (elementary) finishes, I will open a [21.11] Pantheon 6.x.y PR for all updates in the release cycle. The PR is expected to be tested and merged before the next elementary release cycle starts.

All untested PRs will be marked as draft.

Support for stable release

We do provide support for stable release. But due to current manpower, support on both stable release and unstable release is limited.


Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Nov 19, 2021
@ofborg ofborg bot requested a review from davidak November 19, 2021 02:10
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 19, 2021
@bobby285271
Copy link
Member Author

bobby285271 commented Nov 19, 2021

And finally wrote some scripts to help me review changes...

The following content is machine generated and may contain invalid information.


pantheon.wingpanel-indicator-sound: 6.0.0 -> 6.0.1

Comment

No dependency change

To inspect upstream changes

@bobby285271
Copy link
Member Author

bobby285271 commented Nov 19, 2021

Result of nixpkgs-review pr 146574 run on x86_64-linux 1

3 packages built:
  • pantheon.elementary-greeter
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators

@ofborg test pantheon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant