Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

czkawka: 3.2.0 -> 3.3.0 #146757

Merged
merged 3 commits into from
Nov 21, 2021
Merged

czkawka: 3.2.0 -> 3.3.0 #146757

merged 3 commits into from
Nov 21, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Nov 20, 2021 •
edited
Loading

Motivation for this change
  • Upgrade to 3.3.0 incorporating these changes.
  • Adding myself as maintainer
  • Add installCheck
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F requested a review from yanganto November 20, 2021 12:58
@0x4A6F 0x4A6F force-pushed the master-czkawka branch 2 times, most recently from f91e4ba to fb1096b Compare November 20, 2021 14:18
@0x4A6F 0x4A6F marked this pull request as ready for review November 20, 2021 14:19
kira-bruneau
kira-bruneau requested changes Nov 20, 2021
View reviewed changes
pkgs/tools/misc/czkawka/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/czkawka/default.nix
meta = with lib; {
description = "A simple, fast and easy to use app to remove unnecessary files from your computer";
homepage = "https://github.com/qarmin/czkawka";
license = with licenses; [ mit ];
maintainers = with maintainers; [ yanganto ];
maintainers = with maintainers; [ yanganto _0x4A6F ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanganto Would you be ok with sharing maintainership with @0x4A6F?

@kira-bruneau
Copy link
Contributor

Result of nixpkgs-review pr 146757 run on x86_64-linux 1

1 package built:
  • czkawka

@kira-bruneau
Copy link
Contributor

Result of nixpkgs-review pr 146757 run on x86_64-darwin 1

1 package built:
  • czkawka

@r-burns r-burns merged commit 255c284 into NixOS:master Nov 21, 2021
@0x4A6F 0x4A6F changed the title czkawka: 0.3.2 -> 0.3.3 czkawka: 3.2.0 -> 3.3.0 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Artturin left review comments

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@yanganto yanganto Awaiting requested review from yanganto

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x4A6F @kira-bruneau @Artturin @r-burns