Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super-slicer-latest: renamed from super-slicer-staging #146819

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 20, 2021

Motivation for this change

See discussion in #136962 (comment)

I've been thinking about having a seperate 'staging' package. The problem I see with this is that there don't seem to be no real release cycle, i.e. no dedicated staging/preview process. Early versions for a minor version (i.e. 2.3.57.0) seem to be more like an alpha or release candidate in other projects. I.e. after a release is considered stable, releases after that are stable as well for a time.

This would lead to "staging" to potentially be an older versions than "stable". I think I'd be happier with naming it "*-latest" and keeping it always at the latest release.

I'm not sure how other maintainers decide if a separate package for cutting edge releases is appropriate though.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Moredread Moredread requested a review from cab404 November 20, 2021 23:31
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 20, 2021
@cab404
Copy link
Member

cab404 commented Nov 21, 2021

alright, but that needs to be merged before a branchoff.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/413

@cab404 cab404 self-requested a review November 21, 2021 07:22
@cab404
Copy link
Member

cab404 commented Nov 21, 2021

Actually, no, that needs to have a release notes line. @Moredread, please add a note about rename, as per 21.11 Release Notes (or backporting 21.05 Release notes) of PR to-do list.

Copy link
Member

@cab404 cab404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs release notes, as package rename is a breaking change.

- `pkgs.super-slicer-staging` were renamed to `pkgs.super-slicer-latest`
- `pkgs.super-slicer.staging` were renamed to `pkgs.super-slicer.latest`

@cab404
Copy link
Member

cab404 commented Nov 21, 2021

Okay, or not. I am a bit dumb. "staging" was not a part of a previous release, so I guess it shouldn't really hurt to just leave it as, without additional documentation.

@cab404 cab404 self-requested a review November 21, 2021 21:51
@balsoft balsoft merged commit 1a02f09 into NixOS:master Nov 21, 2021
@Moredread
Copy link
Contributor Author

Thanks 😊

@Moredread Moredread deleted the super-slicer-latest branch November 22, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants