Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audacious: 4.0.5 -> 4.1 #147247

Merged
merged 1 commit into from
Nov 25, 2021
Merged

audacious: 4.0.5 -> 4.1 #147247

merged 1 commit into from
Nov 25, 2021

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented Nov 24, 2021

Motivation for this change

4.1 has some bugfixes that would be nice to have in 21.11.

I've added the --disable-gtk flag as it now tries to do a dual Qt/GTK build by default.
I'm not entirely sure how we'd mix GTK/Qt (as we currently use libsForQt5.callPackage), but this can be sorted later.

For now, I'd just like to get the bugfixes in 21.11.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
Review

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • audacious
  • gjay

@fabianhjr
Copy link
Member

fabianhjr commented Nov 25, 2021

Adding backport label per resquest on: #140168 (comment)

EDIT: This will create a backport PR automatically once this PR is merged.

@ofborg ofborg bot requested review from ttuegel and edolstra November 25, 2021 09:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 25, 2021
@SuperSandro2000 SuperSandro2000 merged commit 0a58fdd into NixOS:master Nov 25, 2021
@github-actions
Copy link
Contributor

Successfully created backport PR #147353 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants