WIP remove Python 2 packages #148669
Closed
WIP remove Python 2 packages #148669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI, you can do |
|
What's the motivation for dropping pypy2? Unlike CPython2 it is maintained upstream and is likely to be maintained indefinitely. Moreover, we should just switch python2 stuff to pypy2 if it seems to start like. |
piegamesde
force-pushed
the
remove-python-2
branch
from
7d462c6 to
f0499ee
Compare
|
Again, this is my personal playground at the moment. There is no particular reason for nothing. |
piegamesde
force-pushed
the
remove-python-2
branch
from
f0499ee to
6ed8da4
Compare
The `contrib` folder was removed from the packaging. It contains a lot of files that are irrelevant to the actual package (i.e. Fedora spec files, selinux hardening or systemd services). There are a few scripts in there too but in any case they are misplaced and would be better off in a separate package (as e.g. the Fedora packaging does)
piegamesde
force-pushed
the
remove-python-2
branch
from
6ed8da4 to
6840354
Compare
ofborg
bot
added
10.rebuild-darwin: 0
ehmry
added a commit
that referenced
this pull request
Dec 17, 2021
Python 2 is deprecated. Ref #148669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A DRAFT PR, DO NOT REVIEW This is my personal playground for now because there is no other easy way to get a list of all affected packages.
Motivation for this change
#140168 (comment)
Apparently, that didn't really happen for some reason, so let's do it now. Yes, 6 a.m. is the correct time for those things :)
Also, this is not a graceful operation. I'll just go and rip off everything that still depends on Python 2, unless it has so dependents that there is no way around patching. (I've already been warned about Gtk2)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes