system/activation: ShellCheck output files

[l0b0]

Motivation for this change

#133088

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

@Artturin

[dasJ]

Maybe we should get rid of the issues first and also handle included files?

$ shellcheck /run/current-system/activate

In /run/current-system/activate line 59:
    mkdir -m 0755 -p "$mountPoint"
          ^-- SC2174: When used with -p, -m only applies to the deepest directory.


In /run/current-system/activate line 63:
source /nix/store/g4pp1y486prf9hijwrl8afm0w1vkjf47-mounts.sh
       ^-- SC1091: Not following: /nix/store/g4pp1y486prf9hijwrl8afm0w1vkjf47-mounts.sh was not specified as input (see shellcheck -x).

In /run/current-system/activate line 211:
mkdir -p -m 0755 /run/binfmt
         ^-- SC2174: When used with -p, -m only applies to the deepest directory.


In /run/current-system/activate line 231:
mkdir -m 0755 -p /bin
      ^-- SC2174: When used with -p, -m only applies to the deepest directory.

In /run/current-system/activate line 363:
mkdir -m 0755 -p /usr/bin
      ^-- SC2174: When used with -p, -m only applies to the deepest directory.


In /run/current-system/activate line 376:
mkdir -m 1777 -p /var/tmp
      ^-- SC2174: When used with -p, -m only applies to the deepest directory.