Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages: fix nodejs packages #152764

Merged
merged 1 commit into from
Dec 30, 2021
Merged

elmPackages: fix nodejs packages #152764

merged 1 commit into from
Dec 30, 2021

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Dec 30, 2021 •
edited
Loading 

Fixes regression caused by
4c60ee3da1e3a9c2441ebeb1c755049555624924 (pull: #142915)
following patch of nodePackages using nodejs-14_x
2c3b3e69ad3306fa0711eebdac98e010c7a2d6aa (pull: #149120)

- clenups and updates in generate-node-packages.sh
- specify nodejs version in default.nix

This makes elmPackages.* build with nodejs-14
which resolves the issue with npm installation failing

resolves #152745

cc @jerith666 for review

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Related:

@turboMaCk turboMaCk added the 0.kind: bug Something is broken label Dec 30, 2021
@turboMaCk turboMaCk changed the title elmPackages: fix nodejs packahes elmPackages: fix nodejs packages Dec 30, 2021
@turboMaCk
elmPackages: fix nodejs packages
26b74d2 
    Fixes regression caused by
    4c60ee3 (pull: NixOS#142915)
    following patch of nodePackages using nodejs-14_x
    2c3b3e6 (pull: NixOS#149120)

    - clenups and updates in generate-node-packages.sh
    - specify nodejs version in default.nix

    This makes elmPackages.* build with nodejs-14
    which resolves the issue with npm installation failing
@turboMaCk turboMaCk force-pushed the fix-elm-packages-post-node-16 branch from 1119572 to 26b74d2 Compare December 30, 2021 18:05
@turboMaCk turboMaCk mentioned this pull request Dec 30, 2021
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Dec 30, 2021
@turboMaCk turboMaCk merged commit 4a03790 into NixOS:master Dec 30, 2021
@jerith666
Copy link
Contributor

Belatedly, this looks great and fixes the build for me -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@jerith666 jerith666 Awaiting requested review from jerith666

Assignees
No one assigned
Labels
0.kind: bug Something is broken 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elmPackages - broken nodejs builds
2 participants
@turboMaCk @jerith666