Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: 1.10.3 -> 1.11.1 #153508

Merged
merged 2 commits into from
Jan 4, 2022
Merged

consul: 1.10.3 -> 1.11.1 #153508

merged 2 commits into from
Jan 4, 2022

Conversation

techknowlogick
Copy link
Member

Motivation for this change

Updated consul to latest version which supports darwin/arm64 (hopefully this can be backported, although I'm new to nix and am unsure of exact policies on this)

Things done

Tests run & verified binary runs on darwin/arm64

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest version which supports darwin/arm64 (hopefully this can be backported, although I'm new to nix and am unsure of exact policies on this)

In general we don't backport major updates, and Consul in particular is problematic, because it gives no forward compat at all, meaning that if you upgrade from 1.10 to 1.11, and something breaks, and you decide to roll back, the on-disk data was already permanently upgraded and the old version will refuse to read it.

In any case, where did you get the info about

supports darwin/arm64

from? Maybe a newer 1.10 point release also provides that? That one we could backport to 21.11.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/servers/consul/default.nix Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member Author

@nh2 thank you for your feedback :)

In any case, where did you get the info about

from hashicorp/consul#9852, even though looking at the related PR it only builds the binary. I am unable to get it to build from 1.10.3 (I will test latest tag in 1.10.x branch to see if that works on darwin/arm64, to see if there is something that could be backported).

Please split this into a separate commit in the same PR, so that if the consul commit has to be reverted for some reason, you stay in this list.

Done.

@ofborg ofborg bot requested a review from nh2 January 4, 2022 21:48
@nh2 nh2 merged commit b58ebec into NixOS:master Jan 4, 2022
@nh2
Copy link
Contributor

nh2 commented Jan 4, 2022

Thanks for your contribution!

@techknowlogick techknowlogick deleted the update-consul branch January 5, 2022 00:32
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants