-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consul: 1.10.3 -> 1.11.1 #153508
consul: 1.10.3 -> 1.11.1 #153508
Conversation
62bccf7
to
e409f85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest version which supports darwin/arm64 (hopefully this can be backported, although I'm new to nix and am unsure of exact policies on this)
In general we don't backport major updates, and Consul in particular is problematic, because it gives no forward compat at all, meaning that if you upgrade from 1.10 to 1.11, and something breaks, and you decide to roll back, the on-disk data was already permanently upgraded and the old version will refuse to read it.
In any case, where did you get the info about
supports darwin/arm64
from? Maybe a newer 1.10 point release also provides that? That one we could backport to 21.11.
e409f85
to
6299ff2
Compare
@nh2 thank you for your feedback :)
from hashicorp/consul#9852, even though looking at the related PR it only builds the binary. I am unable to get it to build from 1.10.3 (I will test latest tag in 1.10.x branch to see if that works on darwin/arm64, to see if there is something that could be backported).
Done. |
Thanks for your contribution! |
Motivation for this change
Updated consul to latest version which supports darwin/arm64 (hopefully this can be backported, although I'm new to nix and am unsure of exact policies on this)
Things done
Tests run & verified binary runs on darwin/arm64
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes