Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/switch-to-configuration: avoid Array::Compare dependency #160176

Merged

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Feb 15, 2022

Motivation for this change

Replace Array::Compare with a simple function, since Array::Compare pulls down Module::Build which breaks cross compilation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@stigtsp stigtsp requested a review from dasJ February 15, 2022 14:16
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 15, 2022
@stigtsp stigtsp requested a review from ius February 15, 2022 14:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 15, 2022
Replace Array::Compare with a simple function, since Array::Compare
pulls down Module::Build which breaks cross compilation.
@stigtsp stigtsp force-pushed the fix/switch-to-configuration-array-compare branch from 307e8a3 to 3d713ef Compare February 15, 2022 14:39
Copy link
Contributor

@ius ius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on Perl, but it definitely fixes the cross issue!

@dasJ dasJ merged commit 05e1f8a into NixOS:master Feb 15, 2022
@dasJ
Copy link
Member

dasJ commented Feb 15, 2022

Merged this rather soon-ish because the issue is not on nixos-unstable yet: https://nixpk.gs/pr-tracker.html?pr=157329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants