Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yelp: Use webkit2gtk-4.0 ABI #160278

Merged
merged 1 commit into from
Feb 17, 2022
Merged

yelp: Use webkit2gtk-4.0 ABI #160278

merged 1 commit into from
Feb 17, 2022

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Feb 16, 2022

Motivation for this change

yelp was our only package using the webkit2gtk-4.1 ABI, which inflated the NixOS GNOME ISO with an extra flavor of webkit2gtk.

Fixes part of #159612.

This shrinks the GNOME ISO by 26 MB after compression (2,291,744,768 → 2,266,103,808 bytes).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 16, 2022
@andersk andersk mentioned this pull request Feb 16, 2022
Open
@andersk andersk added 11.by: nixpkgs-member 6.topic: closure size The final size of a derivation, including its dependencies labels Feb 16, 2022
@andersk
yelp: Use webkit2gtk-4.0 ABI
3c6f9a9 
yelp was our only package using the webkit2gtk-4.1 ABI, which inflated
the NixOS GNOME ISO with an extra flavor of webkit2gtk.

Fixes part of NixOS#159612.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@ofborg ofborg bot requested review from dasj19, jtojnar and amaxine February 16, 2022 07:31
@cole-h
Copy link
Member

cole-h commented Feb 16, 2022

@ofborg eval

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Feb 16, 2022
@jtojnar jtojnar merged commit 854a00b into NixOS:master Feb 17, 2022
@andersk andersk deleted the yelp-webkit2gtk branch May 21, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

@amaxine amaxine Awaiting requested review from amaxine

Assignees
No one assigned
Labels
6.topic: closure size The final size of a derivation, including its dependencies 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersk @cole-h @jtojnar