Add a package for ble.sh #160857
Add a package for ble.sh #160857
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
| pname = "blesh"; | ||
| version = "0.3.3"; | ||
|
|
||
| src = fetchgit { |
|
|
||
| src = fetchgit { | ||
| url = "https://github.com/akinomyoga/ble.sh.git"; | ||
| rev = "398e404d624ef6365d9175882e24f6e180d8b6b2"; |
There was a problem hiding this comment.
For version 0.3.3 this could be "v${version}", but the listed revision is not actually a tagged version and so the version number should probably reflect that (i.e. version = "0.4.0_devel3.398e404"; or something.)
| rev = "398e404d624ef6365d9175882e24f6e180d8b6b2"; | ||
| sha256 = "09i6a45lcd8gb0397hcffwsc5fqam8f7wk2yw9qgjjrb7i9n1235"; | ||
| }; | ||
| configurePhase = '' |
There was a problem hiding this comment.
Perhaps makeFlags = [ "--assume-old=contrib/.git" ]; instead.
| configurePhase = '' | ||
| mkdir contrib/.git | ||
| ''; | ||
| installPhase = '' |
There was a problem hiding this comment.
Why not just installFlags = [ "INSDIR=$(out)" ];?
| longDescription = "A full-featured line editor written in pure Bash with Syntax highlighting, auto suggestions, vim modes, etc. in Bash interactive sessions!"; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ aryak ]; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
I would have thought that ble.sh would be portable?
There was a problem hiding this comment.
i have not tested it on macos. so i have mentioned just linux... if someone can confirm that it works on macos i would add it too.
| mv out/doc $out/share/doc/blesh | ||
| mv out $out/share/blesh | ||
| ''; | ||
|
|
There was a problem hiding this comment.
I would find it useful to add the ble.sh shell script to PATH, if that is still acceptable even though it is not an executable. This would do it:
preFixup = ''
mkdir $out/bin
cat >$out/bin/ble.sh <<EOF
source $out/ble.sh
EOF
'';
| rev = "398e404d624ef6365d9175882e24f6e180d8b6b2"; | ||
| sha256 = "09i6a45lcd8gb0397hcffwsc5fqam8f7wk2yw9qgjjrb7i9n1235"; | ||
| }; | ||
| configurePhase = '' |
There was a problem hiding this comment.
Should the dependency on gawk be explicit?, i.e. buildInputs = [ gawk ];.
|
Hey, couldn't check the stuff as i lost access to my github account for a while. I will fix everything tommorow. Thanks for reviewing! |
|
closing in favor of #181963 |
Janik-Haag
added
the
12. first-time contribution
Add a package for ble.sh
Motivation for this change
Add a package for ble.sh, a bash line editor that provides fish-like completions for the bash shell
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes