Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pantheon updates 2022-02-28 #162293

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Pantheon updates 2022-02-28 #162293

merged 2 commits into from
Mar 2, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Mar 1, 2022 •
edited
Loading

Motivation for this change

Pantheon 6.1 follow-ups (previous one at #157716)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Mar 1, 2022
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 1, 2022 •
edited
Loading

I created a trivial GitHub actions workflow so you can now view the list of pending Pantheon changes in https://github.com/bobby285271/what-changed#what-changed

pantheon.elementary-greeter: 6.0.1 → 6.0.2

For now, we only need to make sure the Add support for Mutter 42 PR does not touch anything related to mutter 3.38

A few files that need to check:

  • vapi/libmutter.vapi
  • vapi/mutter-clutter.vapi
  • vapi/mutter-cogl-6.vapi

@bobby285271
Copy link
Member Author

@ofborg test pantheon

@ofborg ofborg bot requested a review from davidak March 1, 2022 02:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 1, 2022
bobby285271
bobby285271 commented Mar 1, 2022
View reviewed changes
pkgs/desktops/pantheon/desktop/elementary-greeter/default.nix
@@ -80,7 +70,6 @@ stdenv.mkDerivation rec {
libhandy
lightdm
mutter
wingpanel-with-indicators
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The greeter uses the panel as its own process for a while so I removed this from buildInputs but this still needs to stay in PATH.

@bobby285271
Copy link
Member Author

Result of nixpkgs-review pr 162293 run on x86_64-linux 1

3 packages built:
  • pantheon.appcenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding

@bobby285271 bobby285271 mentioned this pull request Mar 1, 2022
Merged
13 tasks
@bobby285271 bobby285271 added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Mar 1, 2022
@bobby285271 bobby285271 marked this pull request as ready for review March 1, 2022 08:59
@bobby285271 bobby285271 merged commit 80d84b0 into NixOS:master Mar 2, 2022
@bobby285271 bobby285271 deleted the pantheon branch March 2, 2022 02:21
@bobby285271 bobby285271 added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 8.has: port to stable A PR already has a backport to the stable release. 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobby285271