Revert "buildDotnetModule: enable RestoreUseStaticGraphEvaluation" #162476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b1856b. This broke one of our clients projects where a local libary could no longer be found. Since there is no easy way to disable it's better if this flag is set per project using `dotnetRestoreFlags`.
|
I think this has gotten fixed with dotnet/msbuild#7361, in my opinion we should re-enable the flag once we confirm it fixes these problems and the pull hits a tagged release. In the meantime I'll merge this, thanks for the fix! It's also planned to enable the flag by default, see NuGet/Home#9803. Progress on that looks a bit stale, but seeing how there aren't any open issues left I imagine we won't find more regressions from it. |
IvarWithoutBones
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b1856b.
This broke one of our clients projects where a local libary could no
longer be found. Since there is no easy way to disable it's better
if this flag is set per project using
dotnetRestoreFlags.