-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: add ofek #163088
maintainers: add ofek #163088
Conversation
c676d89
to
c1b8c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed! |
the |
Addressed, thank you! |
description = "Modern, extensible Python build backend"; | ||
homepage = "https://github.com/ofek/hatch"; | ||
license = licenses.mit; | ||
maintainers = with maintainers; [ ofek ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a entry for ofek
has to be added to ./maintainers/maintainer-list.nix
https://nixos.org/manual/nixpkgs/stable/#var-meta-maintainers
the maintainers: add ofek
commit should be before the init commit
and also please fixup the commits where feedback is addressed so once the pr is merged the history will be clean :)
packaging | ||
pathspec | ||
pluggy | ||
tomli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-build . -A python3Packages.hatchling
build fails with
ERROR: Could not find a version that satisfies the requirement tomli~=2.0.0; python_version > "3" (from hatchling) (from versions: none)
ERROR: No matching distribution found for tomli~=2.0.0; python_version > "3"
sadly the tomli update pr hasn't been merged and it also will go in to staging which will take some time to reach the master branch #157735
i will test the builds and if they succeed then merge
so we can either leave this unmerged and then i merge this once the tomli pr is in master or i merge this in to staging
BTW afaik the hatchling does not need to be in nixpkgs for poetry2nix to be able to use it though since hatchling is not poetry, poetry2nix will need to add support for it
Thank you for your patience.
I reordered the commits as requested and relaxed the dependency constraints. Can you please try building again? |
|
||
# All runtime dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# All runtime dependencies |
|
||
pythonImportsCheck = [ "hatchling.build" ]; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The project has tests https://github.com/ofek/hatch/tree/master/tests and missing pythonImportsCheck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the tests try to pull at least one library from the internet.
running install tests
<<<<< Copying backend >>>>>
<<<<< Building backend >>>>>
* Creating virtualenv isolated environment...
* Getting dependencies for wheel...
* Installing packages in isolated environment... (editables>=0.2; python_version > "3", importlib-metadata; python_version < "3.8", packaging>=21.3; python_version > "3", packaging~=20.9; python_version < "3", pathspec>=0.9, pluggy>=1.0.0; python_version > "3", pluggy~=0.13; python_version < "3", tomli>=1.2.2; python_version > "3", toml~=0.10.2; python_version < "3")
Ignoring packaging: markers 'python_version < "3"' don't match your environment
Ignoring toml: markers 'python_version < "3"' don't match your environment
Ignoring pluggy: markers 'python_version < "3"' don't match your environment
Ignoring importlib-metadata: markers 'python_version < "3.8"' don't match your environment
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be410>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59bfe80>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be0e0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be110>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff56fa110>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
ERROR: Could not find a version that satisfies the requirement pathspec>=0.9 (from versions: none)
ERROR: No matching distribution found for pathspec>=0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it tries to install things into a virtualenv.
Already part of python-updates for a datadogpy update. You can pick up maintainership if you want to. |
As described here the tests currently require the Git repository structure. pypa/hatch#120 (comment) If that gets fixed and we can run some tests offline that would certainly be appealing. |
Fixed: |
.Migrated to PyPi source in 70ba57a7f48ee1c826ca6fa9c60bf1bac8a0d8d4. |
Switches to the PyPi source per the upstream maintainers request in #163088 (comment)
Switches to the PyPi source per the upstream maintainers request in #163088 (comment)
Switches to the PyPi source per the upstream maintainers request in #163088 (comment)
Switches to the PyPi source per the upstream maintainers request in #163088 (comment)
Switches to the PyPi source per the upstream maintainers request in #163088 (comment)
Switches to the PyPi source per the upstream maintainers request in #163088 (comment) (cherry picked from commit 455f910)
Switches to the PyPi source per the upstream maintainers request in NixOS#163088 (comment) (cherry picked from commit 455f910)
Switches to the PyPi source per the upstream maintainers request in NixOS#163088 (comment) (cherry picked from commit 455f910)
Switches to the PyPi source per the upstream maintainers request in NixOS#163088 (comment) (cherry picked from commit 455f910)
Motivation for this change
#163088 (comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes