nixos/gnome: set default wallpaper for dark mode as well #166096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: GNOME
|
Looks like the backgrounds currently have different size of NixOS logos: https://gfycat.com/parchednimblearrowcrab Maybe we should just always use the dark one? Ideas @samueldr? |
ofborg
bot
added
10.rebuild-darwin: 0
This was referenced Mar 28, 2022
Merged
jtojnar
force-pushed
the
gnome-default-dark-background
branch
from
4777ad8 to
621810d
Compare
|
The blue background has a same size but it looks slightly odd: nixos-gnome-background.mp4 |
jonringer
approved these changes
Mar 28, 2022
Closed
|
This does not use the official logo and the backgrounds are different. I would like to have a consistent user experience across desktops. |
jtojnar
changed the title
jtojnar
force-pushed
the
gnome-default-dark-background
branch
from
621810d to
1378b58
Compare
jtojnar
changed the title
GNOME 42 needs two wallpaper pictures – for the default (light) colour scheme and for the dark one. Because we are clearing out the paths in `gsettings-desktop-schemas` to prevent closure from bloating, we need to set them in the NixOS module. Since the wallpaper for the default colour scheme is dark, will relegate it to the dark colour scheme and switch to a light blue variant for the default colour scheme. That one has inverted roundel for the NixOS logo but it is the only light-ish background that has the logo of the same size and placing as the dark wallpaper.
jtojnar
force-pushed
the
gnome-default-dark-background
branch
from
1378b58 to
56d27ee
Compare
|
I have updated the commit message to make it clearer. But until we have better wallpaper set designed, the only other alternative is having the same picture for both light and dark colour schemes, which significantly decreases the cool factor. |
|
I can't blame you for using the wallpapers that are available. So OK for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
GNOME 42 needs two wallpaper pictures – for the default (light) colour scheme and for the dark one. Because we are clearing out the paths in
gsettings-desktop-schemasto prevent closure from bloating, we need to set them in the NixOS module.Since the wallpaper for the default colour scheme is dark, will relegate it to the dark colour scheme and switch to a light blue variant for the default colour scheme. That one has inverted roundel for the NixOS logo but it is the only light-ish background that has the logo of the same size and placing as the dark wallpaper.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes