haskellPackages.leveldb-haskell: fix build #166892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnhmjoj
requested review from
cdepillabout,
sternenseemann,
maralorn and
expipiplus1
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
| @@ -23,6 +23,12 @@ self: super: { | |||
| # There are numerical tests on random data, that may fail occasionally | |||
| lapack = dontCheck super.lapack; | |||
|
|
|||
| # fix tests failure for base≥4.15 | |||
| leveldb-haskell = appendPatch (fetchpatch { | |||
| url = "https://github.com/kim/leveldb-haskell/pull/41.patch"; | |||
There was a problem hiding this comment.
Using the commit is a bit more robust as it wouldn't change content on a force push:
Suggested change
| url = "https://github.com/kim/leveldb-haskell/pull/41.patch"; | |
| url = "https://github.com/kim/leveldb-haskell/commit/f5249081f589233890ddb1945ec548ca9fb717cf.patch"; |
There was a problem hiding this comment.
Uhm, it's true but also hides the fact the patch comes from a pull request.
I put the link in the comment.
sternenseemann
pushed a commit
that referenced
this pull request
Apr 2, 2022
|
Cherry-picked as 6a36abc. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix tests failure for base≥4.15.
Things done
sandbox = trueset innix.conf? (See Nix manual)haskellPackages.leveldb-haskellnixos/doc/manual/md-to-db.shto update generated release notes