Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/i2pd: update addressbook subscriptions #167109

Closed
wants to merge 1 commit into from

Conversation

apathyspace
Copy link

Description of changes

Follow the upstream update in the default PurpleI2P/i2pd addressbook subscriptions from 2021-01-27
Minor and trivial change

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Follow the upstream update in the default PurpleI2P/i2pd addressbook subscriptions from 2021-01-27 commit 7c8280934a7a25db6ac802cffdeab4f2f8470b77
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 4, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 4, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2022
@curbengh
Copy link

curbengh commented Dec 31, 2022

I'm quite puzzled why upstream replaced inr.i2p with reg.i2p as default. inr.i2p is still being actively updated and includes much more domains (775 vs 108). I retain inr.i2p in #208451.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 31, 2022
@apathyspace
Copy link
Author

@curbengh I don't remember exactly, but there were some inconsistency at the time. I think inr.i2p didn't carry reg.i2p address or something like that. It all resulted in being unable to resolve torproject.i2p, that's basically the whole reason why I opened this PR.

As for the upstream reason, I wouldn't know, maybe it was the above, maybe having fewer domains in the root node is actually beneficial, with faster loading, or something like that.

@apathyspace
Copy link
Author

Closed in favor of #208451

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants