Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjpeg: include powerpc64le on doCheck=false list #170198

Merged
merged 1 commit into from Apr 27, 2022
Merged

openjpeg: include powerpc64le on doCheck=false list #170198

merged 1 commit into from Apr 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2022

Description of changes

The tests are disabled on arm as well; they do not seem to be
particularly portable tests.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The tests are disabled on arm as well; they do not seem to be
particularly portable tests.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 25, 2022
@ghost
Copy link
Author

ghost commented Apr 26, 2022

Unfortunately #170402 does not help here; the test failure is not due to powerpc64le's non-IEEE long double.

@SuperSandro2000 SuperSandro2000 merged commit 6759286 into NixOS:master Apr 27, 2022
@ghost ghost deleted the openjpeg-disable-checks-on-power64le branch April 27, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant