Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spidermonkey_91: 91.8.0 -> 91.9.0 #172351

Merged
merged 1 commit into from
May 18, 2022
Merged

spidermonkey_91: 91.8.0 -> 91.9.0 #172351

merged 1 commit into from
May 18, 2022

Conversation

lostnet
Copy link
Contributor

@lostnet lostnet commented May 10, 2022 •
edited
Loading

Description of changes

Standard ESR update including security fixes.
Release notes:
https://www.mozilla.org/en-US/firefox/91.9.0/releasenotes/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lostnet lostnet added backport release-21.11 1.severity: security Issues which raise a security issue, or PRs that fix one labels May 10, 2022
@lostnet lostnet marked this pull request as ready for review May 13, 2022 08:36
@mweinelt mweinelt requested a review from ajs124 May 13, 2022 15:34
@mweinelt
Copy link
Member

mweinelt commented May 13, 2022 •
edited
Loading

A bit surprised this targets master. Also Spidermonkey is just the JS-Engine of Firefox, so I don't think the mentioned security issues necessarily apply.

@ajs124
Copy link
Member

ajs124 commented May 13, 2022 •
edited
Loading

Most important things still depend on spidermonkey 78, sadly. See #157874.

Edit: or maybe it's just libproxy? polkit as well? idk. both have duktape support, but haven't made new releases iirc.

@lostnet
Copy link
Contributor Author

lostnet commented May 13, 2022

Yes, unfortunately every monthly releases security disclosure includes a mostly opaque last entry, i.e. https://www.mozilla.org/en-US/security/advisories/mfsa2022-17/#CVE-2022-29917 which may or may not apply to spidermonkey. I wasn't sure if it makes sense to target staging on something tagged security, though this isn't really a not previously disclosed issue or anything.

@mweinelt mweinelt merged commit 6472a13 into NixOS:master May 18, 2022
@github-actions github-actions bot mentioned this pull request May 18, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #173545 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lostnet @mweinelt @ajs124