-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wordpress: Add wordpressPackages #173622
wordpress: Add wordpressPackages #173622
Conversation
pkgs/servers/web-apps/wordpress/packages/wordplress-plugins.json
Outdated
Show resolved
Hide resolved
fixed
|
a803261
to
94c1e83
Compare
@mohe2015 Unfortunately I couldn't manage to generate wordpressPackage sets using the json files generated by wp4nix, still trying to fix this but this is more difficult. Are you familiar with it? |
Nothing came to my eye when looking at this PR but I'm not actively using NixOS any more so I can't check. |
@dasJ @ajs124 @SlothOfAnarchy Thank you for your work on wp4nix. I would like to integrate Wordpress packaging into NixOS using the approach in this PR. I would like to use the generated plugins, themes and language packages using your upstream Nix expression https://github.com/NixOS/nixpkgs/pull/173622/files#diff-e90349d673d80a4089a94ec946a314282f197cb3d431436a633ecd203fab0c8a
Unfortunately it currently fails
Do you remember what was the right way to get this integrated? |
e9648e2
to
bafc7e9
Compare
Thanks to your work @mohe2015 I was able to get it to work :) |
This PR is ready for review :) |
Description of changes
This is the continuation of #124383 (thanks to @mohe2015 ) for packaging Wordpress plugins and themes. Similar to nodePackages, this approach uses a script (wp4nix) to generate Nix expressions using a list of package or theme names in json files.
So the workflow would be:
wordpress-plugins.json
file./generate.sh
pkgs.wordpressPackages.plugins.antispam-bee
in the Wordpress module like this:This is also described in the
README.md
.Todos
README.md
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes