Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3bro: remove use_2to3 #174148

Merged
merged 1 commit into from
May 23, 2022
Merged

s3bro: remove use_2to3 #174148

merged 1 commit into from
May 23, 2022

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 23, 2022

Description of changes

Fix build (https://hydra.nixos.org/build/177072130)

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented May 23, 2022

Result of nixpkgs-review pr 174148 run on x86_64-linux 1

1 package built:
  • s3bro

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15, nixos x86_64 & aarch64

@risicle risicle merged commit 7c7d71d into NixOS:master May 23, 2022
@github-actions
Copy link
Contributor

Successfully created backport PR #174191 for release-22.05.

@tjni tjni mentioned this pull request Jun 14, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants