Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obsoleted] Pantheon: default to mutter 42 #174279

Closed
wants to merge 0 commits into from
Closed

[Obsoleted] Pantheon: default to mutter 42 #174279

wants to merge 0 commits into from

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented May 24, 2022 •
edited
Loading

Description of changes

#170361

pantheon.switchboard-plug-mouse-touchpad: 6.1.0 -> 7.0.0
pantheon.switchboard-plug-keyboard: 2.7.0 -> 3.0.0
pantheon.elementary-shortcut-overlay: 1.2.1 -> 2.0.0

All packages included in this PR must be updated together due to some schema changes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label May 24, 2022
@bobby285271 bobby285271 self-assigned this May 24, 2022
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment labels May 24, 2022
@ofborg ofborg bot requested a review from davidak May 24, 2022 14:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels May 24, 2022
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels May 24, 2022
@bobby285271 bobby285271 added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 25, 2022
@bobby285271 bobby285271 force-pushed the pantheon branch 2 times, most recently from 137801a to 76e00be Compare September 9, 2022 13:42
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 9, 2022
@bobby285271 bobby285271 mentioned this pull request Sep 26, 2022
Merged
13 tasks
@bobby285271 bobby285271 removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Oct 7, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 7, 2022
@bobby285271 bobby285271 changed the base branch from master to bobby285271/gnome-snapshot-81e445e October 12, 2022 23:59
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 13, 2022
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 13, 2022
@bobby285271
Copy link
Member Author

bobby285271 commented Oct 13, 2022 •
edited
Loading

@ofborg test pantheon

@bobby285271 bobby285271 changed the base branch from bobby285271/gnome-snapshot-81e445e to master October 13, 2022 06:17
@bobby285271 bobby285271 marked this pull request as ready for review October 13, 2022 06:36
@bobby285271 bobby285271 requested a review from jtojnar as a code owner October 13, 2022 06:36
@bobby285271
Copy link
Member Author

bobby285271 commented Oct 13, 2022 •
edited
Loading

  • Can not resize Picture-in-Picture window
  • Multitasking view: clicking empty place does not quit the view
  • Remove unused fetchpatch from args 🙉

@bobby285271 bobby285271 marked this pull request as draft October 13, 2022 14:30
SuperSandro2000
SuperSandro2000 reviewed Oct 14, 2022
View reviewed changes
pkgs/desktops/gnome/default.nix Outdated
# Using 3.38 to match Mutter used in Pantheon
gnome-settings-daemon338 = callPackage ./core/gnome-settings-daemon/3.38 { };
# Using 42 to match Mutter used in Pantheon
gnome-settings-daemon42 = callPackage ./core/gnome-settings-daemon/42 { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gnome-settings-daemon42 = callPackage ./core/gnome-settings-daemon/42 { };
gnome-settings-daemon42 = callPackage ./core/gnome-settings-daemon/42.nix { };

The structure right now is a bit weird. Normally we would do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are extra patches so we need to use a subdirectory.

SuperSandro2000
SuperSandro2000 reviewed Oct 14, 2022
View reviewed changes
pkgs/desktops/gnome/default.nix Outdated
# Needed for elementary's gala and greeter until support for higher versions is provided
mutter338 = callPackage ./core/mutter/3.38 { };
# Needed for Pantheon's gala, wingpanel and greeter until support for higher versions is provided.
mutter42 = callPackage ./core/mutter/42 { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mutter42 = callPackage ./core/mutter/42 { };
mutter42 = callPackage ./core/mutter/42.nix { };

@bobby285271 bobby285271 mentioned this pull request Oct 15, 2022
Merged
13 tasks
@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Oct 18, 2022
@bobby285271
Copy link
Member Author

Ah sorry I pushed the wrong branch, let me open a new PR

@bobby285271
Copy link
Member Author

#196511

@bobby285271 bobby285271 mentioned this pull request Oct 26, 2022
Closed
13 tasks
@bobby285271 bobby285271 changed the title Pantheon: default to mutter 42 [Obsoleted] Pantheon: default to mutter 42 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@davidak davidak Awaiting requested review from davidak

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

@bobby285271 bobby285271

Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobby285271 @jtojnar @SuperSandro2000