libidn2: hack to avoid referencing bootstrap tools #175785
Conversation
|
Eh, well, the conflict is trivial to resolve, now I rather want this to be testable without a stdenv rebuild. This approach is the best I could come with, though perhaps someone will have a better idea or some nits to improve in this PR. |
ofborg
bot
added
the
2.status: merge conflict
| buildInputs = [ patchelf ]; | ||
|
|
||
| passthru = { | ||
| inherit (libidn2) out info devdoc; # no need to touch these store paths |
There was a problem hiding this comment.
This leads to unexpected results when requesting libidn2 from the CLI, which generally works with drvPath and its libstore-level outputs, rather than the outputs attribute. I'm proposing to redefine "package" in Nix here NixOS/nix#6507.
There was a problem hiding this comment.
Presumably it works fine when used in expressions though.
It is only a bit of a problem when doing nix-build -A libidn2.
There was a problem hiding this comment.
What are you getting from that command? I'm getting the right -bin output, i.e. the one without boostrap tools in closure. (also with nix build)
There was a problem hiding this comment.
libidn2.all is a bit confusing, though I don't think it has so much usage. I also tried to make that not too bad... so you're missing info and devdoc, and out only differs by adding a symlink layer.
There was a problem hiding this comment.
Right, it's more of a problem with the new CLI's output selector syntax, which operates at the store level (via drvPath) rather than the expression level.
There was a problem hiding this comment.
$ nix-build -A libidn2.info
/nix/store/klbv14mif5q34nqj04v2bgv9d7qv2pk6-libidn2-2.3.2-info
$ nix build .#libidn2^info --print-out-paths
warning: Git tree '/home/user/h/nixpkgs' is dirty
error: derivation '/nix/store/zy3r4mqqb8wsljg1cfdnw02mqplaqw8n-libidn2-2.3.2.drv' does not have wanted outputs 'info'
There was a problem hiding this comment.
Oh I forgot to mention that stuff like libidn2.info.bin is also broken by such overrides, and I don't know a nice way of fixing that. (But again, I think it's rarely used.)
bobby285271
added
the
12.approvals: 1
Due to bootstrap tools getting purged from closure of libidn2.dev, a very large rebuild is caused.
bobby285271
removed
the
12.approvals: 1
|
I'll assume that we take this until a better proposal appears. |
Due to bootstrap tools getting purged from closure of libidn2.dev,
a very large rebuild is caused.
Fixes #175693
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes