nixos/modules/system/boot/loader/raspberrypi: enable u-boot support for rpi 4 #176018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
allows installation of u-boot to the /boot directory of a rpi4 system via
whereas previously
version = 4
would have triggered an assertion in the derivation.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesi've been using this for about a month on the raspberry pi 400, which uses the same SOC as the rpi4.
i haven't tested the 32-bit code path.
it's not clear to me why support was previously disabled at this level: i think it's just an artifact of history.
the nixos SD image gained support for rpi4 in cc5baf2 (2019/08/17).
that commit added the branch which throws "U-Boot is not yet supported on the raspberry pi 4" (which my patch removes).
nixpkgs u-boot gained rpi4 support in 95cd8c8 (2020/09/12).
i think at that point we could have enabled rpi support here but it was overlooked.
tagging @tkerber for his earlier involvement in this area.