Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlab: remove unused dylib of human_name #176240

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jun 4, 2022

Description of changes

We don't need the dylib build of human_name, only the rlib build. It only adds to the closure size by referencing rustc.

> nix-store --query --tree /nix/store/8qki9p7x164wn78l857f0dx0a7xvl5i7-texlab-4.0.0
/nix/store/8qki9p7x164wn78l857f0dx0a7xvl5i7-texlab-4.0.0
└───/nix/store/fz33c1mfi2krpg1lwzizfw28kj705yg0-glibc-2.34-210
    ├───/nix/store/kas3xyzrwq7fpriy1v2gyvhi0bgv7zav-libidn2-2.3.2
    │   ├───/nix/store/16y41vgaiwpsrm784b2743682r8r0bb6-libunistring-1.0
    │   │   └───/nix/store/16y41vgaiwpsrm784b2743682r8r0bb6-libunistring-1.0 [...]
    │   └───/nix/store/kas3xyzrwq7fpriy1v2gyvhi0bgv7zav-libidn2-2.3.2 [...]
    └───/nix/store/fz33c1mfi2krpg1lwzizfw28kj705yg0-glibc-2.34-210 [...]

Fixes #95568

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kira-bruneau kira-bruneau requested a review from doronbehar June 4, 2022 12:49
@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Jun 4, 2022

I tried looking again if there was a better way to just disable the dylib build. It looks like it might still be a limitation: rust-lang/rust#56443 (comment).

I'm not sure if anything's changed since then, but the issue's still open, so I'm assuming not 😞

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 176240 run on x86_64-linux 1

1 package built:
  • texlab

@doronbehar doronbehar merged commit 093d2bd into NixOS:master Jun 4, 2022
@doronbehar
Copy link
Contributor

Thanks a lot again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

texlab references rustc
2 participants