buildRustCrate: pass link flags when building libraries #177436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Rust 1.61, it is necessary to link to external static/dynamic libaries when building the rlib that uses them, rather than when linking the final binary. In fact, it is no longer necessary to specify the libraries to link when building the final binary, but the library search path flags must still be included.
rcgen depends on ring, and therefore exercises support for static libraries
|
This looks good to me. The CI issue at the moment is likely unrelated. |
|
@GrahamcOfBorg eval |
ofborg
bot
added
10.rebuild-darwin: 0
|
Thank you, I think we are good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With Rust 1.61, it is necessary to link to external static/dynamic libaries when building the rlib that uses them, rather than when linking the final binary. In fact, it is no longer necessary to specify the libraries to link (
-l) when building the final binary, but the library search path flags (-L) must still be included.I figured this out by comparing
buildRustCrate's rustc arguments with those used by cargo, and haven't identified the upstream commit that changed this behavior.I added a test that builds the
rcgenpackage, which triggers this issue because it depends onring. It has quite a few dependencies, so if someone knows of a simpler test case, I'd be happy to switch. This test fails to cross-compile due to an existing issue described here: #138321 (comment)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @Ericson2314 @happysalada