Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: 3.7.3 -> 4.0.0 #178421

Merged
merged 1 commit into from
Jun 21, 2022
Merged

tdesktop: 3.7.3 -> 4.0.0 #178421

merged 1 commit into from
Jun 21, 2022

Conversation

kilianar
Copy link
Contributor

Description of changes

Updated with update.py.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kilianar
Copy link
Contributor Author

Result of nixpkgs-review pr 178421 run on x86_64-linux 1

1 package built:
  • tdesktop

@ofborg ofborg bot requested a review from oxalica June 21, 2022 10:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 21, 2022
K900
K900 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, runs just fine here.

@thiagokokada thiagokokada merged commit 22f87e0 into NixOS:master Jun 21, 2022
@muscaln muscaln mentioned this pull request Jun 22, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@K900 K900 K900 approved these changes

@oxalica oxalica Awaiting requested review from oxalica

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kilianar @K900 @thiagokokada @NickCao