Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cro-mag-rally: init at 3.0.0 #179978

Merged
merged 1 commit into from
Feb 3, 2024
Merged

cro-mag-rally: init at 3.0.0 #179978

merged 1 commit into from
Feb 3, 2024

Conversation

luxzeitlos
Copy link
Contributor

Description of changes

Add Cro-Mag Rally package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@luxzeitlos luxzeitlos mentioned this pull request Jul 3, 2022
Open
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 3, 2022
azahi
azahi requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@azahi azahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine but I have a couple of nitpicks. Also, I think you should add an XDG desktop file as well.

@luxzeitlos
Copy link
Contributor Author

I think you should add an XDG desktop

honestly I'm not sure how to; and we dont have them for the other ex-pangeasoft-games (otto-matic, nanosaur, bugdom) either, so idk.

@azahi
Copy link
Member

azahi commented Jul 7, 2022 •
edited
Loading

Something like this (I didn't test that):

postInstall = ''
  install -Dm644 $src/packaging/cromagrally.desktop $out/share/applications/cromagrally.desktop
  install -Dm644 $src/packaging/cromagrally-desktopicon.png $out/share/pixmaps/cromagrally-desktopicon.png
'';

This way people can launch the game from their desktop environment and not just from a terminal.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 25, 2023
@luxzeitlos luxzeitlos force-pushed the cro-mag-rally branch 2 times, most recently from 23ef10e to e2999c8 Compare February 1, 2024 22:09
h7x4
h7x4 reviewed Feb 1, 2024
View reviewed changes
@h7x4
Copy link
Member

h7x4 commented Feb 1, 2024

(Also, feel free to ping someone or request a reviewer or two when this much time passes without interaction. This PR has been as good as ready for quite some time now, I think it's long overdue)

yayayayaka
yayayayaka reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looking good overall. Built and started the game. Weird game 😆

With the nitpicks applied, I would be willing to boop the merge button.

@luxzeitlos @azahi @h7x4
cro-mag-rally: init at 3.0.0-unstable-2023-05-21
a1fa666 
Co-authored-by: Azat Bahawi <azat+github@bahawi.net>
Co-authored-by: h7x4 <h7x4@nani.wtf>
@luxzeitlos
Copy link
Contributor Author

@yayayayaka I think it looks good now?

@yayayayaka yayayayaka requested a review from azahi February 2, 2024 15:10
@azahi azahi merged commit b7b8316 into NixOS:master Feb 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 left review comments

@yayayayaka yayayayaka yayayayaka left review comments

@azahi azahi azahi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luxzeitlos @azahi @h7x4 @yayayayaka