-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5, libsForQt5: 5.14 -> 5.15 on darwin #184560
Conversation
This doesn't appear quite ready for merge. At the very least, my attempt to build qt5 on aarch64 is failing with qtspeech. @jiegec |
The Qt 5.14 was always ready but not fully ready for x86_64-darwin. The |
Of course -- sorry, haven't had my coffee yet. Right, and put more literally for the purpose of this PR, Can any |
The reason why qt5 was kept at qt5.12 on darwin was that qt5.qtwebengine is broken on x86_64-darwin for qt5.14+ as per nixpkgs/pkgs/development/libraries/qt-5/modules/qtwebengine.nix Lines 261 to 265 in a6cb63c
Since it seems qt5 was bumped to qt5.14, the default qt5.qtwebengine is already broken on x86_64-darwin and therefore we don't lose anything by bumping to qt5.15 (where qtwebengine is broken too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this works in runtime: #185615
@veprbl if the last bump caused a regression a revert is absolutely the right move, and I’ll move this to draft. Sorry for the mixup. |
@willcohen @veprbl according reports in #185615 issue affects Qt 5.14, but not Qt 5.15 So maybe bumping to 5.15 will fix it? |
Description of changes
Per https://github.com/NixOS/nixpkgs/pull/168524/files#r934306285, qt515 is ready to become the default on macos. I don't have an x86 mac anymore, so I can't test personally.
@veprbl @jiegec
Things done
Bumped qt514 to qt515.
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes