glibc: enable stackprotection hardening #18522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables previously manually disabled stackprotector and stackguard randomization. From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=511811: If glibc is built with the --enable-stackguard-randomization option, each application gets a random canary value (at runtime) from /dev/urandom. If --enable-stackguard-randomization is absent, applications get a static canary value of "0xff0a0000". This is very unfortunate, because the attacker may be able to bypass the stack protection mechanism, by placing those 4 bytes in the canary word, before the actual canary check is performed (for example in memcpy-based buffer overflows).
fpletz
added
1.severity: mass-rebuild
|
In favor of squeezing it into 16.09, myself. |
|
Sure, but let's create a staging-16.09 branch from 16.09 to always have binaries on (I also feel something else might come up in a week or so, then we can get these changes in together). |
vcunat
added a commit
that referenced
this pull request
Sep 12, 2016
|
I was able to build lots of packages without any problem. In standard staging now; Hydra building already. |
|
We have not seen any build failures on our hydra either, so should be safe. I've created a staging-16.09 branch. Can somebody please add a jobset to Hydra? |
|
Maybe we could wait anyway for the regular staging to finish its rebuild (~10k queued ATM), but it seems very unlikely to cause a mass breakage. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables previously manually disabled stackprotector (#1) and stackguard randomization.
From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=511811:
@domenkozar Provided it doesn't break any builds, can we maybe get it into 16.09? We missed this in #12895 and we feel it's important. Unfortunately a full rebuild is required. 😞
cc @vcunat