Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "qt5, libsForQt5: 5.12 -> 5.14 on darwin" #185616

Closed
wants to merge 1 commit into from
Closed

Revert "qt5, libsForQt5: 5.12 -> 5.14 on darwin" #185616

wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 8, 2022

Reverts #168524

The original change came without any testing on the target platform and caused a regression.

Fixes: #185615

@veprbl veprbl requested a review from ttuegel as a code owner August 8, 2022 00:06
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 8, 2022
@veprbl veprbl force-pushed the revert-168524-qt-5.14-darwin branch from e264d46 to 0a3c770 Compare August 8, 2022 00:40
@veprbl veprbl force-pushed the revert-168524-qt-5.14-darwin branch from 0a3c770 to 0dc7321 Compare August 8, 2022 02:21
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 8, 2022
@alyssais alyssais requested a review from willcohen August 8, 2022 05:30
@willcohen
Copy link
Contributor

The benefit of 5.14 over 5.12 was just that it was "less" end-of-life, but I'm highly in favor of reverting if there's any breakages being detected.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 10, 2022
@veprbl
Copy link
Member Author

veprbl commented Aug 14, 2022

@tanshihaj Does this fix your issue?

@tanshihaj
Copy link
Contributor

No, downgrading to 5.12 will not help me since qt support aarch64-darwin starting from 5.15. So maybe better to bump it to 5.15?

@veprbl
Copy link
Member Author

veprbl commented Aug 14, 2022

@tanshihaj So you are saying that qt5 was broken on aarch64-darwin all this time? I have not seen any issue filed for that...

@willcohen
Copy link
Contributor

That’s been my understanding as well — other broken aarch64 stuff has messed up my home install so I haven’t had a chance to test on my new M2 machine though.

@veprbl
Copy link
Member Author

veprbl commented Aug 14, 2022 •
edited
Loading

Search reveals, there is one issue #130240
and this one is relevant #147817
as the clang 5 toolchain is likely the main cause for incompatibility

@tanshihaj
Copy link
Contributor

@veprbl yes qt5 was broken on aarch64-darwin all this time, moreover it was explicitly disabled here https://github.com/NixOS/nixpkgs/blame/7908242f926b3df62b46e98a69e88a2a60265125/pkgs/development/libraries/qt-5/modules/qtbase.nix#L377 until I've fixed build for Qt 5.15 here: 940b020

@veprbl veprbl closed this Aug 16, 2022
@veprbl veprbl deleted the revert-168524-qt-5.14-darwin branch August 16, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willcohen willcohen willcohen approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qt5 applications broken on darwin
4 participants
@veprbl @willcohen @tanshihaj @bobby285271