-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixVersions.nix_2_11: init at 2.11.0 #188777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the fallback paths too.
LGTM otherwise.
If you read the top post you'll see that this in another PR. |
I'm on my phone, so it was hidden. Just cherry-pick into this branch so they land together. |
Elco always said in the past that it does not matter to much if they are merged together or not. |
Observation: If that commit was a separate PR it'd make backporting to stable easier (just label the PR). |
Then we would need to merge 3 PRs at the same time. Not very practical. |
AFAICT it's 2 PRs, and they dont have to be merged at the same time, but we must ensure they are merged in correct order. |
So either way people still need to do two PRs except opening two on master is more complicated? |
I don't think that is worth it for the little convince improvement. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesnix-fallback-paths
done in #188772