-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin nixpkgs registry to pkgs.path via nix.settings.registry #189113
Conversation
…kgs.path via boot.postBootCommands
this would be much better done in |
@pennae That doesn't solve anything. If you run |
ah, mistakenly thought this piece also goes into the installed system. that'll also obviate the |
I support the idea. Does not work on my machine:
For the record I'm building a custom iso but I don't think that makes a difference. |
@MatthewCroughan nope. Same error. I'd love to help better but I'm out of my depth with the flakes magic. I would like this to be possible other than setting nix.registry.nixpkgs.to = {
type = "path";
path = pkgs.path;
}; |
…kgs.path via nix.settings.registry
6a7eefe
to
31dbd4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please squash the commits
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good afaiac
Description of changes
This is a suggestion of something that would be needed in order to allow #189048 to function correctly. Otherwise the registry entry the user's
nix
will generate when faced with a/etc/nixos/flake.nix
that does not contain aninputs
attribute, will be ambigious and non-reproducible. We set thenix-channel
appropriately inchannel.nix
for this same reason.I provide two commits for doing this, and I'm not sure which approach is better.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes