Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublime4: pin to openssl_1_1 #191379

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

PedroHLC
Copy link
Member

@PedroHLC PedroHLC commented Sep 15, 2022

Description of changes

It broke somewhere in the past week, I was traveling and received a week of updates so bisecting it would be hard, what I know from the broken state:

╰─λ ./plugin_host-3.8
./plugin_host-3.8: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory

╰─λ LD_PRELOAD=$PWD/libcrypto.so.1.1 ./plugin_host-3.8
./plugin_host-3.8: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

╰─λ ldd plugin_host-3.8 | grep crypto
  libcrypto.so.1.1 => not found

╰─λ LD_LIBRARY_PATH=$PWD ./plugin_host-3.8
./plugin_host-3.8: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory

Error from sublime's GUI:

screenshot


And it worked once I did:

╰─λ LD_LIBRARY_PATH=/nix/store/a4g2mals99rhsq1q7rydszz5b5bhzbm3-openssl-1.1.1q/lib LD_PRELOAD=/nix/store/a4g2mals99rhsq1q7rydszz5b5bhzbm3-openssl-1.1.1q/lib/libcrypto.so.1.1 ./plugin_host-3.8
Unexpected number of arguments, expected 6

So I've hard-coded this version. And made sure to remove the libraries bundled with the package to skip patching and for us to easily notice when they change the version.

Things done

Built both sublime4 and sublime4-dev, worked perfectly.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@PedroHLC
Copy link
Member Author

Result of nixpkgs-review pr 191379 run on x86_64-linux 1

2 packages built:
  • sublime4
  • sublime4-dev

@PedroHLC PedroHLC marked this pull request as ready for review September 15, 2022 20:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 15, 2022
@jtojnar
Copy link
Member

jtojnar commented Sep 15, 2022

Probably caused by #150093.

@jtojnar jtojnar merged commit bef209d into NixOS:master Sep 16, 2022
@PedroHLC PedroHLC deleted the sublime4-pin-openssl_1_1 branch October 11, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants