Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rabbitmq config decryption #192620

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Fix rabbitmq config decryption #192620

merged 3 commits into from
Sep 28, 2022

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 23, 2022

Description of changes

rabbitmq-server: Use openssl_1_1 to fix config decryption

Fixes #192499, nixosTests.rabbitmq

Reverts the effect of the openssl upgrade introduced in 0565276 #150093

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@roberth roberth requested a review from turion September 23, 2022 13:51
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Sep 23, 2022
@turion
Copy link
Contributor

turion commented Sep 23, 2022

Does RabbitMQ not (yet) support OpenSSL 3.0? Would be nice if we can switch there eventually.

@roberth
Copy link
Member Author

roberth commented Sep 24, 2022

The RabbitMQ docs aren't explicit about the openssl dependency, but their Docker stuff is, and it's all OpenSSL 1.1. I agree.

turion
turion approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@turion turion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor doc nitpick, but I think this is great!

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 26, 2022
@roberth roberth force-pushed the issue-192499-fix-rabbitmq-config-decrypt branch from b79cd65 to 0c797e0 Compare September 28, 2022 09:18
@ofborg ofborg bot requested a review from turion September 28, 2022 09:33
@turion turion merged commit b6fe86f into NixOS:master Sep 28, 2022
@roberth
Copy link
Member Author

roberth commented Sep 28, 2022

Thank you for the review @turion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rabbitmq-server doesn't load encrypted secret files anymore
3 participants
@roberth @turion @bobby285271