nncp: 8.8.0 -> 8.8.1

[ehmry]

Description of changes

The main improvements are:

• Fixed "nncp-daemon" failing with unauthenticated connection and
  enabled "-autotoss".
• Updated dependencies.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[viraptor]

On darwin/intel:

       > In file included from /nix/store/qlri4s3662flhy1y3lzq8j1hpvnf8xnp-apple-framework-Foundation-11.0.0/Library/Frameworks/Foundation.framework/Headers/Foundation.h:87:
       > In file included from /nix/store/qlri4s3662flhy1y3lzq8j1hpvnf8xnp-apple-framework-Foundation-11.0.0/Library/Frameworks/Foundation.framework/Headers/NSURLCredential.h:9:
       > In file included from /nix/store/a3wz3bgl85yy9g0l2nlys7y05z76lgbg-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/Security.h:87:
       > /nix/store/a3wz3bgl85yy9g0l2nlys7y05z76lgbg-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/SecCode.h:35:10: fatal error: 'xpc/xpc.h' file not found
       > #include <xpc/xpc.h>
       >          ^~~~~~~~~~~
       > 1 error generated.
       > redo      bin/nncp-ack (exit 2)
       > redo    bin/all (exit 1)
       > redo  install (exit 1)

[viraptor]

Changing the entry in all-packages.nix to:

nncp = darwin.apple_sdk_11_0.callPackage ../tools/misc/nncp { };

fixes the darwin build.

[ehmry]

@viraptor does 60d425b0a590cfcb8c974d79d13735b90ea97cb0 work for you?

[viraptor]

Nope. Same issue (https://github.com/NixOS/nixpkgs/pull/198701/checks?check_run_id=9193516054)

It's not about the security framework itself, but rather weirdness with xpc which was fixed in the newer sdk.

[ehmry]

Okay. I know nothing of such things.

[viraptor]

This works for all systems, but affects darwin only. It's safe to use unconditionally.

Suggested change

	nncp = (
	if stdenv.isDarwin
	then darwin.apple_sdk_11_0.callPackage
	else callPackage) ../tools/misc/nncp { };
	nncp = darwin.apple_sdk_11_0.callPackage ../tools/misc/nncp { };

It's not the best solution ever 🤷 but it's necessary for some packages. (see others like _7zz or mlterm in this file)

The sdk comes from #176661 if you want the gory details.

[woffs]

A look at doc/stdenv/platform-notes.chapter.md and the definition of even go itself in all-packages.nix seems to confirm this. So if this fixes the darwin build and if the linux build is still fine, go for it.

[divanorama]

Sorry to jump in, in #200033 I was looking at a different package with same error and this didn't help

diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 51a52a44915..9d74ffcd8dd 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -16353,7 +16353,7 @@ with pkgs;
 
   bazel-remote = callPackage ../development/tools/build-managers/bazel/bazel-remote { };
 
-  bazel-watcher = callPackage ../development/tools/bazel-watcher {
+  bazel-watcher = (if stdenv.isDarwin then darwin.apple_sdk_11_0.callPackage else callPackage) ../development/tools/bazel-watcher {
     go = go_1_18;
   };

on x86_64-darwin it still gets

In file included from /nix/store/gvz6j31hm9hg44xiwb503rbv2gc1x0nw-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/Security.h:87:
/nix/store/gvz6j31hm9hg44xiwb503rbv2gc1x0nw-apple-framework-Security-11.0.0/Library/Frameworks/Security.framework/Headers/SecCode.h:35:10: fatal error: 'xpc/xpc.h' file not found
#include <xpc/xpc.h>
         ^~~~~~~~~~~
1 error generated.
compilepkg: error running subcommand external/go_sdk/pkg/tool/darwin_amd64/cgo: exit status 2
Target //ibazel:ibazel failed to build

any hints?

[SuperSandro2000]

This shouldn't have been merged like this. darwin.apple_sdk_11_0.callPackage is a noop for linux. Going to fix it up right now.

[ehmry]

No, I'm not using darwin and I don't want my packages fed through darwin functions.

[SuperSandro2000]

Then the apple 11 sdk usage must be removed instead. Plotting conditionals around the callPackage use is not necessary and unnecessary.

[woffs]

A look at doc/stdenv/platform-notes.chapter.md and the definition of even go itself in all-packages.nix seems to confirm this. So if this fixes the darwin build and if the linux build is still fine, go for it.