cinnamon.cinnamon-control-center: Fix some localization issues #199139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
cinnamon-settings is a weird app, some of the modules are actually loaded from the external cinnamon-control-center app (which is a forked gnome-control-center but most users never directly opens it), so to fix translations sometimes you need to fix there.
We do pass
localedir
to cinnamon-control-center, but cinnamon-control-center does not always respect this and what they do is:The situation is still better than the previous Pantheon, though, and we can resolve most issues by simply
sed
all the paths so I am doing it here. Making proper fix on upstream is possible but I don't have the time so far, note that is still a little different from Pantheon since cinnamon-control-center does not contain the translations itself and again it is loaded from external packages 😴Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes